Project

General

Profile

Anomalie #1349

Reply-To not used

Added by Johan Cwiklinski 24 days ago. Updated 16 days ago.

Status:
Fermé
Priority:
Normal
Category:
Emails
Target version:
Start date:
06/20/2018
Due date:
06/20/2018
% Done:

100%

Estimated time:
Version utilisée:
Vote:

Description

A reply-to do exist in Galette preferences, but this is not used anymore.

Needs investigaiton to know when it disapeared.


Related issues

Follows Galette - Anomalie #1188: Envoi par messagerieFermé06/19/2018

Actions

Associated revisions

Revision 27d39455 (diff)
Added by Johan Cwiklinski 21 days ago

Always use reply-to when defined; closes #1349

History

#1

Updated by Johan Cwiklinski 24 days ago

  • Due date set to 06/20/2018
  • Start date changed from 11/18/2019 to 06/20/2018
  • Follows Anomalie #1188: Envoi par messagerie added
#2

Updated by Johan Cwiklinski 24 days ago

  • Version utilisée changed from 0.9.3 to 0.9.2

See https://bugs.galette.eu/issues/1188#note-5

So, indeed, after commit ab95c9a8632a648ec1b8eca2c52ab62c49a6cc17 the pref_reply_to preference is no longer used. Either this should be removed from preferences, or it should always be used if defined.

#3

Updated by Johan Cwiklinski 24 days ago

To always use replyto:

diff --git a/galette/lib/Galette/Core/GaletteMail.php b/galette/lib/Galette/Core/GaletteMail.php
index 4438f4e4d..0472bf1a6 100644
--- a/galette/lib/Galette/Core/GaletteMail.php
+++ b/galette/lib/Galette/Core/GaletteMail.php
@@ -240,7 +240,11 @@ public function send()
         );
         // Add a Reply-To field in the mail headers.
         // Fix bug #6654.
-        $this->mail->AddReplyTo($this->getSenderAddress());
+        if ($this->preferences->pref_email_reply_to) {
+            $this->mail->AddReplyTo($this->preferences->pref_email_reply_to);
+        } else {
+            $this->mail->AddReplyTo($this->getSenderAddress());
+        }

         if ($this->html) {

#4

Updated by Roland Telle 24 days ago

Johan Cwiklinski a écrit :

To always use replyto:
[...]

Le patch ne fonctionne pas. L'adresse Répondre à n'apparaît toujours pas dans le header.

#5

Updated by Alain Paris 23 days ago

Bonjour,

Je viens d'essayer , "modification d'une fiche adhérent" envoi a l'adhérent (sur une adresse Outlook) en faisant répondre j'ai bien la bonne adresse ,et je reçois bien a l'adresse "Courriel de réponse".Ajout d'une cotisation aussi...

Avec dernière Nightly et modification comme ci dessus de GaletteMail.php. Utilisation de SMTP.

#6

Updated by Johan Cwiklinski 21 days ago

Roland, pourrais-tu me mettre en destinatinataire d'un de tes tests que je puisse voir ce qui est envoyé ?

#7

Updated by Johan Cwiklinski 21 days ago

  • Category set to Emails
  • Assignee set to Johan Cwiklinski
  • Target version set to 0.9.3
#8

Updated by Johan Cwiklinski 21 days ago

  • Status changed from Nouveau to Résolu
  • % Done changed from 0 to 100
#9

Updated by Johan Cwiklinski 16 days ago

  • Status changed from Résolu to Fermé

Also available in: Atom PDF