Project

General

Profile

Actions

Anomalie #1694

closed

Mass add contribution fail if data is missing

Added by Johan Cwiklinski about 1 year ago. Updated about 1 year ago.

Status:
Fermé
Priority:
Normal
Category:
Core
Target version:
Start date:
09/19/2023
Due date:
% Done:

100%

Estimated time:
Version utilisée:

Description

On 0.9.x and 1.x, if date or extension is missing, mass adding a contribution will fail.

On 1.x, even when some errors are declared, form is sent but messages only appears in logs

127.0.0.1 - 2023-09-19 17:59:15 - ERROR - Some errors has been threw attempting to edit/store a contributionArray
(
    [0] => - Champ obligatoire <a href="#date_enreg">Date</a> vide.
    [1] => - Champ obligatoire <a href="#date_debut_cotis">Date de début d’adhésion</a> vide.
)

Actions #1

Updated by Johan Cwiklinski about 1 year ago

  • Description updated (diff)
Actions #2

Updated by Johan Cwiklinski about 1 year ago

  • Status changed from Nouveau to In Progress
  • Assignee set to Johan Cwiklinski

With no error, I confirm contribution extension is created on all selected users.

I'll have to investigate to see if that's OK when there is an error on one of the selected members because of fee overlapping for example; this will be handled in a different ticket.

Actions #3

Updated by Guillaume AGNIERAY about 1 year ago

Johan Cwiklinski a écrit (#note-2):

With no error, I confirm contribution extension is created on all selected users.

I can confirm this too.

I'll have to investigate to see if that's OK when there is an error on one of the selected members because of fee overlapping for example; this will be handled in a different ticket.

I can already confirm there is indeed at least an error because of fee overlapping (on 0.9.x and 1.x).

  • With 1.x in logs :
      127.0.0.1 - 2023-09-22 10:06:03 - ERROR - Some errors has been threw attempting to edit/store a contributionArray
      (
          [0] => - La période d’adhésion chevauche la période commençant le 22/09/2023
      )
      
  • Slim error displayed on screen on 0.9.x, and recoverable in jqXHR object on 1.x :
      405 Method Not Allowed
    
      The application could not run because of the following error:
    
      Details
    
      Type: Slim\Exception\HttpMethodNotAllowedException
      Code: 405
      Message: Method not allowed. Must be one of: POST
      File: /var/html/galette/galette/vendor/slim/slim/Slim/Middleware/RoutingMiddleware.php
      Line: 79
    
      Trace
    
      #0 /var/html/galette/galette/vendor/slim/slim/Slim/Middleware/RoutingMiddleware.php(44): Slim\Middleware\RoutingMiddleware-&gt;performRouting()
      #1 /var/html/galette/galette/vendor/slim/slim/Slim/MiddlewareDispatcher.php(121): Slim\Middleware\RoutingMiddleware-&gt;process()
      #2 /var/html/galette/galette/vendor/slim/slim/Slim/Middleware/ErrorMiddleware.php(76): Psr\Http\Server\RequestHandlerInterface@anonymous-&gt;handle()
      #3 /var/html/galette/galette/vendor/slim/slim/Slim/MiddlewareDispatcher.php(121): Slim\Middleware\ErrorMiddleware-&gt;process()
      #4 /var/html/galette/galette/vendor/slim/twig-view/src/TwigMiddleware.php(115): Psr\Http\Server\RequestHandlerInterface@anonymous-&gt;handle()
      #5 /var/html/galette/galette/vendor/slim/slim/Slim/MiddlewareDispatcher.php(121): Slim\Views\TwigMiddleware-&gt;process()
      #6 /var/html/galette/galette/vendor/slim/slim/Slim/MiddlewareDispatcher.php(65): Psr\Http\Server\RequestHandlerInterface@anonymous-&gt;handle()
      #7 /var/html/galette/galette/vendor/slim/slim/Slim/App.php(199): Slim\MiddlewareDispatcher-&gt;handle()
      #8 /var/html/galette/galette/vendor/slim/slim/Slim/App.php(183): Slim\App-&gt;handle()
      #9 /var/html/galette/galette/includes/main.inc.php(244): Slim\App-&gt;run()
      #10 /var/html/galette/galette/webroot/index.php(57): require_once('...')
      #11 {main}
      
Actions #4

Updated by Johan Cwiklinski about 1 year ago

  • Status changed from In Progress to Résolu
  • % Done changed from 0 to 100
Actions #5

Updated by Johan Cwiklinski about 1 year ago

  • Status changed from Résolu to Fermé
Actions

Also available in: Atom PDF